feat: give more actionable advice regarding binary incompatibilities due to duplication on the classpath. #1306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

autonomousapps merged 2 commits into main from trobalik.duplicate-classpath

Nov 14, 2024

Owner

autonomousapps commented Nov 12, 2024

No description provided.

github-actions bot commented Nov 12, 2024

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/4ony7riyyha64
* TestKit buildHealth      : https://gradle.com/s/4la5w5lqfgcnm
* Non-functional tests     : https://gradle.com/s/4gp7sseqwrq4q
* TestKit check            : https://gradle.com/s/6pege66gjwytu
* JVM functional tests     : https://gradle.com/s/6npi7epk2ofc4
* Android functional tests :

autonomousapps changed the title ~~wip~~ feat: give more actionable advice regarding binary incompatibilities due to duplication on the classpath.

github-actions bot commented Nov 12, 2024

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/4nnrxrs6ndeuy
* TestKit buildHealth      : https://gradle.com/s/c4g6jo7uybn7y
* Non-functional tests     : https://gradle.com/s/6jkdgavwoxwjy
* TestKit check            : https://gradle.com/s/5tim5cjzx3r64
* JVM functional tests     : https://gradle.com/s/xlm37vv33b4ws
* Android functional tests :

github-actions bot commented Nov 12, 2024

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/tf3ken33bfh46
* TestKit buildHealth      : https://gradle.com/s/qxrr5xicys472
* Non-functional tests     : https://gradle.com/s/ybixpaviingt6
* TestKit check            : https://gradle.com/s/qgs5kuqxlqwgi
* JVM functional tests     : https://gradle.com/s/dig655ms3miqs
* Android functional tests : https://gradle.com/s/g76tdawr5v5i2

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/model/Capability.kt Outdated Show resolved Hide resolved

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/model/intermediates/consumer/MemberAccess.kt Show resolved Hide resolved

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/tasks/ComputeUsagesTask.kt Outdated Show resolved Hide resolved

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/tasks/ComputeUsagesTask.kt Outdated Show resolved Hide resolved

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/tasks/ComputeUsagesTask.kt Outdated Show resolved Hide resolved

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/tasks/ComputeUsagesTask.kt Show resolved Hide resolved

github-actions bot commented Nov 14, 2024

❌ Test workflow failed:

* Root buildHealth         : https://gradle.com/s/clrxlmakf5cle
* TestKit buildHealth      : https://gradle.com/s/cphaw3k7f4dl2
* Non-functional tests     : https://gradle.com/s/5cohkuwhqxwew
* TestKit check            : https://gradle.com/s/hn7q2wmbga3r4
* JVM functional tests     : https://gradle.com/s/gssnqh56ptaa4
* Android functional tests : https://gradle.com/s/q6vs2xzf3i66e

autonomousapps force-pushed the trobalik.duplicate-classpath branch from 2db55b3 to 247e012 Compare

November 14, 2024 20:01

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/model/intermediates/producer/BinaryClass.kt Show resolved Hide resolved

autonomousapps added 2 commits

November 14, 2024 12:04


          feat: check binary compatibility when there are duplicate classes on …

e0ee278

…the classpath.


          test: cleanup fixtures after each test run on CI.

autonomousapps force-pushed the trobalik.duplicate-classpath branch from 247e012 to 1836404 Compare

November 14, 2024 20:04

autonomousapps commented

View reviewed changes

src/main/kotlin/com/autonomousapps/tasks/ComputeUsagesTask.kt Show resolved Hide resolved

autonomousapps marked this pull request as ready for review

November 14, 2024 20:14

autonomousapps merged commit 49aed0b into main

1 check passed

autonomousapps deleted the trobalik.duplicate-classpath branch

November 14, 2024 21:05

autonomousapps mentioned this pull request

revert: feat: check binary compatibility when there are duplicate classes on the classpath. #1311

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet