Merge pull request #286 from autoscrape-labs/fix/support-to-proxy-schema

Add support to proxy schema

Author: thalissonvs

pydoll/browser/managers/browser_process_manager.py

@@ -55,7 +55,7 @@ def start_browser_process(
     @staticmethod
     def _default_process_creator(command: list[str]) -> subprocess.Popen:
         """Create browser process with output capture to prevent console clutter."""
-        return subprocess.Popen(command, stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL)
+        return subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
 
     def stop_process(self):
         """

pydoll/browser/managers/proxy_manager.py

@@ -74,9 +74,17 @@ def _parse_proxy(proxy_value: str) -> tuple[bool, Optional[str], Optional[str],
             return False, None, None, proxy_value
 
         try:
+            scheme = ''
+            has_scheme = False
+            if '://' in proxy_value:
+                scheme, proxy_value = proxy_value.split('://', 1)
+                has_scheme = True
+
             creds_part, server_part = proxy_value.split('@', 1)
             username, password = creds_part.split(':', 1)
-            return True, username, password, server_part
+
+            clean_proxy = f"{scheme}://{server_part}" if has_scheme else server_part
+            return True, username, password, clean_proxy
         except ValueError:
             return False, None, None, proxy_value
 

tests/test_managers/test_browser_managers.py

@@ -66,6 +66,26 @@ def test_proxy_manager_invalid_credentials_format(proxy_options):
     ]
 
 
+def test_proxy_manager_with_scheme_http(proxy_options):
+    proxy_options.add_argument('--proxy-server=http://user:[email protected]:8080')
+    manager = ProxyManager(proxy_options)
+    result = manager.get_proxy_credentials()
+
+    assert result[0] is True
+    assert result[1] == ('user', 'pass')
+    assert proxy_options.arguments == ['--proxy-server=http://proxy.local:8080']
+
+
+def test_proxy_manager_with_scheme_socks(proxy_options):
+    proxy_options.add_argument('--proxy-server=socks5://alice:[email protected]:1080')
+    manager = ProxyManager(proxy_options)
+    result = manager.get_proxy_credentials()
+
+    assert result[0] is True
+    assert result[1] == ('alice', 'pwd')
+    assert proxy_options.arguments == ['--proxy-server=socks5://1.2.3.4:1080']
+
+
 def test_proxy_manager_invalid_proxy_format(proxy_options):
     proxy_options.add_argument('--proxy-server=invalidformat')
     manager = ProxyManager(proxy_options)