Skip to content

Fix a timeout problem in the block_check_memory_leak test on s390x#4441

Closed
huth wants to merge 1 commit intoautotest:masterfrom
huth:fixes
Closed

Fix a timeout problem in the block_check_memory_leak test on s390x#4441
huth wants to merge 1 commit intoautotest:masterfrom
huth:fixes

Conversation

@huth
Copy link

@huth huth commented Feb 12, 2026

Since valgrind is instrumenting the application (memory accesses are examined, and the binary code of the application is JIT recompiled), this can cause massive slowdowns of QEMU. On s390x, when the guest is configured with a virtio-gpu device and the guest is writing its boot messages to that device, too (i.e. when Plymouth in the guest writes all boot messages to the graphical console), these slowdowns are even so high that they can cause some timeouts in systemd of the guest, so that the boot process of the guest fails.

To still be able to run the block_check_memory_leak on s390x, too, let's disable the virtio-gpu device here to avoid the systemd timeouts. The test is about checking for memory leaks in the block layer, so disabling the graphical console should not change the target area of this test.

Buglink: https://issues.redhat.com/browse/RHEL-102982

ID: 5049

Summary by CodeRabbit

  • Chores
    • Added configuration support for an additional system architecture with platform-specific display settings.

Since valgrind is instrumenting the application (memory accesses are
examined, and the binary code of the application is JIT recompiled),
this can cause massive slowdowns of QEMU. On s390x, when the guest is
configured with a virtio-gpu device and the guest is writing its boot
messages to that device, too (i.e. when Plymouth in the guest writes
all boot messages to the graphical console), these slowdowns are
even so high that they can cause some timeouts in systemd of the guest,
so that the boot process of the guest fails.

To still be able to run the block_check_memory_leak on s390x, too,
let's disable the virtio-gpu device here to avoid the systemd timeouts.
The test is about checking for memory leaks in the block layer, so
disabling the graphical console should not change the target area of
this test.

Buglink: https://issues.redhat.com/browse/RHEL-102982
Signed-off-by: Thomas Huth <thuth@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Feb 12, 2026

Walkthrough

A new s390x-specific architecture configuration was added to the block_check_memory_leak.cfg file, setting vga = none for this architecture alongside existing arm64-pci and arm64-mmio leakage threshold configurations. The change consists of two additional lines with no modifications to logic, error handling, or existing configurations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding s390x-specific VGA configuration to fix a timeout problem in block_check_memory_leak test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@huth huth marked this pull request as draft February 12, 2026 14:02
@huth
Copy link
Author

huth commented Feb 12, 2026

This is not working reliably, I need to reconsider, so I'm closing this PR again

@huth huth closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant