Skip to content
This repository was archived by the owner on Jun 25, 2024. It is now read-only.

Conversation

@bbjubjub2494
Copy link
Contributor

@bbjubjub2494 bbjubjub2494 commented May 21, 2024

There are a few instances of fetchFromGitLab in the repo, for instance gtk-doc.src.

My primary goal when writing this was changing the output derivation following #11. This is doable with a lot less diff in fetchFromGitLab, but it's worth asking whether both fetchers should be different and why. I think a lot of the divergence comes from years of random commits rather than from design.

@Sorixelle
Copy link
Member

I'd be inclined to rework both, and use what exists now as a base for a generic fetchFromGitForge that both fetchFromGitHub and fetchFromGitlab can be defined in terms of.

@bbjubjub2494 bbjubjub2494 changed the title fetchFromGitLab: align with fetchFromGitHub fetchFromGitLab: force re-fetch when rev changes Jun 4, 2024
@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review June 4, 2024 20:29
@bbjubjub2494
Copy link
Contributor Author

I tried working on the refactor in a branch, but I am not comfortable writing such code for production because there seem to be too many small details in the original code like complex passthroughs and unsafe functions that I don't know the purpose of.
https://github.com/bbjubjub2494/auxolotl_core/tree/fetchfromgitforge

I would suggest we do the minimal diff thing for now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants