Skip to content

Conversation

@samliok
Copy link
Collaborator

@samliok samliok commented Dec 8, 2025

  1. A node fails to produce a finalization for a round.
  2. The node does not advance to the next round(maybe there are no blocks to be built)
  3. The node triggers rebroadcastFinalizeVotes to try to make progress.
  4. All other nodes have already finalized that round. So they drop the finalize vote message.
  5. The node still sees no progress and keeps rebroadcasting.
  6. With no new blocks being built, the node remains stuck in this loop using unnecessary network bandwidth.

yacovm
yacovm previously approved these changes Dec 8, 2025
@yacovm
Copy link
Collaborator

yacovm commented Dec 8, 2025

2025-12-08T18:14:57.3262338Z goroutine 5652 [sync.Cond.Wait, 8 minutes]:
2025-12-08T18:14:57.3262460Z sync.runtime_notifyListWait(0xc004b11d30, 0x0)
2025-12-08T18:14:57.3262669Z    /opt/hostedtoolcache/go/1.23.12/x64/src/runtime/sema.go:587 +0x159
2025-12-08T18:14:57.3262759Z sync.(*Cond).Wait(0xc004b11d20)
2025-12-08T18:14:57.3262938Z    /opt/hostedtoolcache/go/1.23.12/x64/src/sync/cond.go:71 +0x75
2025-12-08T18:14:57.3263211Z github.com/ava-labs/simplex/testutil.(*InMemStorage).WaitForBlockCommit(0xc004b11d10, 0x1e)
2025-12-08T18:14:57.3263405Z    /home/runner/work/Simplex/Simplex/testutil/storage.go:69 +0x10f
2025-12-08T18:14:57.3263923Z github.com/ava-labs/simplex_test.testReplicationNotarizationWithoutFinalizations(0xc0019fd520, 0x1e, {0xc0036ab4a0, 0x4, 0x4})
2025-12-08T18:14:57.3264131Z    /home/runner/work/Simplex/Simplex/replication_test.go:888 +0xf56
2025-12-08T18:14:57.3264531Z github.com/ava-labs/simplex_test.TestReplicationNotarizationWithoutFinalizations.func1(0xc0019fd520)
2025-12-08T18:14:57.3264728Z    /home/runner/work/Simplex/Simplex/replication_test.go:842 +0x6d
2025-12-08T18:14:57.3264833Z testing.tRunner(0xc0019fd520, 0xc001fdd140)
2025-12-08T18:14:57.3265098Z    /opt/hostedtoolcache/go/1.23.12/x64/src/testing/testing.go:1690 +0x227
2025-12-08T18:14:57.3265224Z created by testing.(*T).Run in goroutine 5505
2025-12-08T18:14:57.3265482Z    /opt/hostedtoolcache/go/1.23.12/x64/src/testing/testing.go:1743 +0x826

Looks like this test hangs

@yacovm yacovm dismissed their stale review December 8, 2025 18:20

Let's look at the test before we merge. It may be related

@yacovm yacovm merged commit 1bbabbb into main Dec 8, 2025
5 checks passed
@samliok samliok deleted the send-finalization branch January 6, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants