Skip to content

Comments

TmpNet on Local Networks#2576

Merged
felipemadero merged 81 commits intomainfrom
localnetworks-tmpnet
Feb 19, 2025
Merged

TmpNet on Local Networks#2576
felipemadero merged 81 commits intomainfrom
localnetworks-tmpnet

Conversation

@felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented Jan 26, 2025

Why this should be merged

Closes #2509 #2510 #2511

Replaces ANR with TmpNet for implementation of local network deploys.

How this works

How this was tested

How is this documented

@felipemadero felipemadero requested a review from a team as a code owner January 26, 2025 03:53
@felipemadero felipemadero marked this pull request as draft January 26, 2025 03:53
Copy link

@maru-ava maru-ava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies for the delay! As suggested, this review is limited in scope to the areas mentioned in channel. My broad recommendations:

  • Maybe try to minimize reading tmpnet networks sincetmpnet.ReadNetwork both reads network and node configuration from disk but also reads the nodes' process context files and checks if the nodes are running. Not super expensive but also not something I'd suggest executing in a wait loop.
  • Feel free to propose the export of functions/methods from the tmpnet package where it makes sense, especially those providing paths to files that tmpnet reads and writes from since that behavior needs to stay synchronized.

@felipemadero felipemadero merged commit 5d4805c into main Feb 19, 2025
37 checks passed
@felipemadero felipemadero deleted the localnetworks-tmpnet branch February 19, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Create TMPNET package/service within CLI

4 participants