Conversation
maru-ava
reviewed
Feb 11, 2025
There was a problem hiding this comment.
My apologies for the delay! As suggested, this review is limited in scope to the areas mentioned in channel. My broad recommendations:
- Maybe try to minimize reading tmpnet networks since
tmpnet.ReadNetworkboth reads network and node configuration from disk but also reads the nodes' process context files and checks if the nodes are running. Not super expensive but also not something I'd suggest executing in a wait loop. - Feel free to propose the export of functions/methods from the tmpnet package where it makes sense, especially those providing paths to files that tmpnet reads and writes from since that behavior needs to stay synchronized.
sukantoraymond
approved these changes
Feb 19, 2025
maru-ava
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #2509 #2510 #2511
Replaces ANR with TmpNet for implementation of local network deploys.
How this works
How this was tested
How is this documented