Rename network type from kind to type#2582
Conversation
…li into rename-network-type
meaghanfitzgerald
added this to the
Separate Node Provisioning from Node Infrastructure Creation milestone
| } | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
|
|
||
| output, err := commands.ListValidators(subnetName, "local") |
There was a problem hiding this comment.
I believe this test does not need to be removed, but ListValidators implementation fixed (really blockchain validators fixed)
| } | ||
|
|
||
| // Gas Kind | ||
| // Gas Type |
There was a problem hiding this comment.
you probably want to rename other Gas Kind relayer stuff, eg promptGasTokenKind, defaultsKind, etc. I mean, this comment relates to Gas Kind so all other stuff also applies (or keep comment unmodified for the moment on)
| networkoptions.NonLocalSupportedNetworkOptions, | ||
| "", | ||
| ) | ||
| setGlobalNetworkFlags(network) |
There was a problem hiding this comment.
why do we continue using globalNetworkFlags after the network is decided? most probably
we need to avoid using flags from here onwards
There was a problem hiding this comment.
I don't think we need this functon, the idea is to generate network from flags, not the other way
|
|
||
| func printAddrInfos(addrInfos []addressInfo) { | ||
| header := []string{"Kind", "Name", "Subnet", "Address", "Token", "Balance", "Network"} | ||
| header := []string{"Type", "Name", "Subnet", "Address", "Token", "Balance", "Network"} |
There was a problem hiding this comment.
again, if we replace here, probably we want to replace all addIngo.kind stuff, or avoid replacing here
felipemadero
left a comment
felipemadero
left a comment
There was a problem hiding this comment.
you also continue having e2e issues. please use latest ANR to fix those.
3 participants
This PR: