Localclusters tmpnet by felipemadero · Pull Request #2680 · ava-labs/avalanche-cli

felipemadero · 2025-03-12T22:23:27Z

Why this should be merged

Closes #2579 #2091 #2528 #2688

There is also a couple of minor extra features added on it:

support specifying http and staking port for local cluster l1 validators
support blockchain aliases on local clusters
minor improvements in network status output

How this works

How this was tested

How is this documented

… info

sukantoraymond · 2025-03-20T20:56:09Z

It solves #2688, does this mean we can have two separate active clusters of local machine validator now at the same time?

sukantoraymond · 2025-03-20T20:57:14Z

I think it does since it also solves #2528

cmd/blockchaincmd/add_validator.go

cmd/blockchaincmd/convert.go

cmd/networkcmd/stop.go

felipemadero · 2025-03-21T15:09:28Z

I think it does since it also solves #2528

Both issues are pretty similar. Answer is yes we can have two separate local clusters at the same time.

sukantoraymond · 2025-03-21T15:57:25Z

pkg/utils/common.go

+	string, // nodeID
+	string, // public key
+	string, // PoP


should we just return a nodeID object here, instead of three strings?

I prefer this reformatting to be done on another PR

pkg/ux/output.go

pkg/localnet/avalanchegoDbDownload.go

sukantoraymond · 2025-03-21T16:58:18Z

pkg/localnet/localnet.go

+				} else if !hasValidators {
+					continue
+				}
+				blockchainBootstrapped, err := IsLocalClusterBlockchainBootstrapped(app, clusterName, blockchain.ID.String(), blockchain.SubnetID)


why not just assign blockchainBootstrappedOnSomeCluster here

we iterate over all the clusters , the last one can be false and overwrite some previous true value. I believe it is cleaner this way that to assign to blockchainBootstrappedOnSomeCluster, check the value and break if true

ok will implement the version with break

sukantoraymond · 2025-03-21T17:10:03Z

pkg/localnet/localcluster.go

+func GetFilteredLocalClusters(
+	app *application.Avalanche,
+	running bool,
+	network models.Network,
+	blockchainName string,
+) ([]string, error) {


Seems that this function is used whenever running = true, should we remove this from argument?

I would rather prefer to keep the option available for the future. It is useful for debugging and dev tasks.

sukantoraymond · 2025-03-21T17:46:25Z

AVL-7H2W7V:avalanche-cli raymondsukanto$ ./bin/avalanche node local destroy newSubnet-local-node-fuji
AVL-7H2W7V:avalanche-cli raymondsukanto$ ./bin/avalanche node local destroy newSubnet2-local-node-fuji

Seems that node local destroy doesn't output anything.
We should prob output that its destroyed.

sukantoraymond · 2025-03-25T15:48:12Z

AVL-7H2W7V:avalanche-cli raymondsukanto$ ./bin/avalanche blockchain deploy localnetowrk
Found running cluster fujiSubnet-local-node-fuji. Will restart after migration.
Unexpected format on cluster at /Users/raymondsukanto/.avalanche-cli/local/local-local-node-local-network. Please manually recover
Migrating fujiSubnet-local-node-fuji
Migrating newSubnet-local-node-local-network
Restarting cluster fujiSubnet-local-node-fuji.

After i upgrade to a new cli release using this PR, If i want to deploy a new local network, seems that I have to wait a while for migration if i have any local nodes left (which people will do if they dont call node local destroy), can we give them an option if they want to migrate? If they dont' want to migrate, we will just destroy these local nodes instead of migrating them

felipemadero added 30 commits January 23, 2025 18:43

start/stop/clean start working for basic local network

6212ea6

add missing files

d1f3bfa

goimports

f73096e

move network load and stop inside tmpnet file

dd8dc6f

improve bootstrapping status check and have better names for localnet…

bda1f25

… info

centralize tmpnet usage. fix status partially

7199092

make network start to use given avalanchego

dd63037

some refactors

813576f

more refactoring

fc5e164

cleanup

af21cc2

refactor

bb2ac3e

preparing to work on track

4325c48

move blockchain boostrapping check to tmpnet

a695bbe

added blockchain config stuff

4acc692

saving RPCs into sidecar

0ce9210

local network non sovereign flow kind of migrated

a70da78

add missing file

ad4f1ff

adding health info to status

7444466

fixed output

b64cdb8

lint

fe1eb4a

Merge branch 'main' into localnetworks-tmpnet

db4c51a

fix go.mod

75979a0

fix licenses

0f176b7

make clean to not fail if no network up

36d24d3

add wait before setting aliases

af05ddc

only set aliases on validators

1fd0cf6

improve alias and bootstrap check functions to base on subnet id

1359373

rm debugging print

cd0403f

fix for a e2e

2e37069

fix more e2e

30ba489

felipemadero added 2 commits March 20, 2025 13:19

nit

7b35f93

lint

ee39da0

sukantoraymond reviewed Mar 20, 2025

View reviewed changes

cmd/blockchaincmd/add_validator.go Outdated Show resolved Hide resolved

sukantoraymond reviewed Mar 20, 2025

View reviewed changes

cmd/blockchaincmd/add_validator.go Outdated Show resolved Hide resolved

sukantoraymond reviewed Mar 20, 2025

View reviewed changes

cmd/blockchaincmd/convert.go Show resolved Hide resolved

sukantoraymond reviewed Mar 20, 2025

View reviewed changes

cmd/networkcmd/stop.go Show resolved Hide resolved

address RS comments

60f3f8c

sukantoraymond reviewed Mar 21, 2025

View reviewed changes

pkg/ux/output.go Outdated Show resolved Hide resolved

sukantoraymond reviewed Mar 21, 2025

View reviewed changes

pkg/localnet/avalanchegoDbDownload.go Outdated Show resolved Hide resolved

set up aliases only for local network clusters

7fe675e

sukantoraymond reviewed Mar 21, 2025

View reviewed changes

avoid retrieving subnet validators

d506132

felipemadero added 3 commits March 26, 2025 11:44

bump avago

394fd9a

fix e2e

39b0adc

address RS comments

aa3ee65

sukantoraymond approved these changes Mar 26, 2025

View reviewed changes

github-project-automation bot moved this from Backlog 🗄️ to In Review 👀 in avalanchego Mar 26, 2025

felipemadero merged commit 8ef7ea8 into main Mar 26, 2025
37 checks passed

felipemadero deleted the localclusters-tmpnet branch March 26, 2025 17:27

github-project-automation bot moved this from In Review 👀 to Done ✅ in avalanchego Mar 26, 2025

This was referenced Mar 26, 2025

[Bug]: Second deployed local blockchain removes RPC node of first blockchain #2688

Closed

[Bug]: Can't spin up multiple local L1s #2528

Closed

Migrating ANR to TMPNET [with subtasks] #2091

Closed

Comments

Conversation

felipemadero commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why this should be merged

How this works

How this was tested

How is this documented

Uh oh!

sukantoraymond commented Mar 20, 2025

Uh oh!

sukantoraymond commented Mar 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felipemadero commented Mar 21, 2025

Uh oh!

sukantoraymond Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

felipemadero Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

felipemadero Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sukantoraymond Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

felipemadero Mar 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

felipemadero Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

sukantoraymond Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

felipemadero Mar 26, 2025

Choose a reason for hiding this comment

Uh oh!

sukantoraymond commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sukantoraymond commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

felipemadero commented Mar 12, 2025 •

edited

Loading

felipemadero Mar 26, 2025 •

edited

Loading

sukantoraymond commented Mar 21, 2025 •

edited

Loading

sukantoraymond commented Mar 25, 2025 •

edited

Loading