fix: install script location default & parsing #2681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sets default location to `~/.local/bin` (standard location on Linux, macOS, etc) - removes trailing slash from install path (prevents cases like `install.sh -b /usr/local/bin/` producing `ava-labs/avalanche-cli info installed /usr/local/bin//avalanche`) Signed-off-by: Kainoa Kanter <[email protected]>
ThatOneCalculator
requested review from
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
ThatOneCalculator
changed the title
this is a non-standard location and will not be recognized in $PATH on pretty much any machine, but is kept here for backwards compatibility and *apparently* being 'easy to remember or locate'
Author
|
Requesting review from @felipemadero |
Collaborator
|
Thank you for the contribution, and apologies for the delay! We've included an improved version of your fix in #2994 - the trailing slash removal now happens after all argument parsing so it works for both the -b flag and environment variable cases. Appreciate you catching this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Removes trailing slash from install path (prevents cases like
install.sh -b /usr/local/bin/producingava-labs/avalanche-cli info installed /usr/local/bin//avalanche)How this works
BINDIRto itself but with trailing slash removed if it existsBINDIRto default if it's an empty stringHow this was tested
How is this documented