Conversation
felipemadero
requested review from
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| &startFlags.UserProvidedAvagoVersion, | ||
| "avalanchego-version", | ||
| constants.DefaultAvalancheGoVersion, | ||
| constants.FujiAvalancheGoV113, |
Contributor
There was a problem hiding this comment.
this is for local network, not needed imo since we only need for fuji
cmd/blockchaincmd/deploy.go
Outdated
| &userProvidedAvagoVersion, | ||
| "avalanchego-version", | ||
| constants.DefaultAvalancheGoVersion, | ||
| constants.FujiAvalancheGoV113, |
Contributor
There was a problem hiding this comment.
changing FujiAvalancheGoV113 to new version is better, since we already have this
avalanche-cli/cmd/blockchaincmd/deploy.go
Line 488 in 3fee311
cmd/nodecmd/local.go
Outdated
| cmd.Flags().StringVar( | ||
| &useCustomAvalanchegoVersion, | ||
| "custom-avalanchego-version", | ||
| constants.FujiAvalancheGoV113, |
Contributor
There was a problem hiding this comment.
this will break the fix i made today, lets undo this change and just change the constant
Collaborator
Author
|
already done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
signature aggregator for fuji
How this works
How this was tested
How is this documented