reduce panic chance by checking CallToMethod return len on all cases#2695
Merged
sukantoraymond merged 7 commits intomainfrom Mar 26, 2025
Merged
reduce panic chance by checking CallToMethod return len on all cases#2695sukantoraymond merged 7 commits intomainfrom
sukantoraymond merged 7 commits intomainfrom
Conversation
felipemadero
requested review from
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
| } | ||
|
|
||
| func GetRegisteredValidator( | ||
| func GetValidationID( |
Contributor
pkg/contract/contract.go
Outdated
| return out, nil | ||
| } | ||
|
|
||
| func GetMethodReturn[T any](methodName string, out []interface{}) (T, error) { |
Contributor
There was a problem hiding this comment.
GetSmartContractCallResult?
Tonix517
approved these changes
Mar 26, 2025
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
sukantoraymond
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented