make SDK to not depend on pkg/models#2711
Merged
sukantoraymond merged 3 commits intomainfrom Apr 10, 2025
Merged
Conversation
felipemadero
requested review from
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
Contributor
|
Why not entirely remove models.network |
Collaborator
Author
that is planned for a subsequent ticket, as models.Network implementation is coupled with CLI clusters main goal here is just to free sdk from pkg deps in a clear way, and prepare SDK for all validator manager logic |
sukantoraymond
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Step on works towards SDK 2.0
How this works
How this was tested
How is this documented