add signal interrupt to local network contexts#2717
Merged
felipemadero merged 6 commits intomainfrom Apr 7, 2025
Merged
Conversation
felipemadero
requested review from
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
ARR4N
reviewed
Apr 3, 2025
Contributor
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
Thank you for adding these features!
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com> Signed-off-by: felipemadero <felipe.madero@gmail.com>
Collaborator
Author
Thanks to you for the good feedbacks |
| if len(logPaths) != 0 { | ||
| printFunc("Please check this log files for more information on the error cause:") | ||
| for _, logPath := range logPaths { | ||
| printFunc(" " + logPath) |
Contributor
There was a problem hiding this comment.
Can we add unit test for helpers_test.go where we intentionally cause error and verify that we get the expected logs dir
Collaborator
Author
There was a problem hiding this comment.
added test for GetTmpNetAvailableLogs
sukantoraymond
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR addresses a couple of suggestions by @ARR4N and @martineckardt , together with fixing a cleaning up issue found
while looking at the problem:
How this works
Example of how it is now telling to the user on the logs
How this was tested
How is this documented