control default latest version for avago and subnetevm#2724
Merged
sukantoraymond merged 23 commits intomainfrom May 1, 2025
Merged
control default latest version for avago and subnetevm#2724sukantoraymond merged 23 commits intomainfrom
sukantoraymond merged 23 commits intomainfrom
Conversation
sukantoraymond
requested review from
cwend-ava,
jasonatran,
learyce and
meaghanfitzgerald
sukantoraymond
commented
Apr 7, 2025
sukantoraymond
commented
Apr 7, 2025
pkg/models/compatibility.go
Outdated
Comment on lines
13
to
14
| LatestVersion string `json:"latest-version"` | ||
| RequirePrerelease bool `json:"require-prerelease"` |
Contributor
Author
There was a problem hiding this comment.
This is for case like #2674, where we had to use a prerelease for fuji only
sukantoraymond
commented
Apr 9, 2025
Collaborator
felipemadero
left a comment
felipemadero
left a comment
There was a problem hiding this comment.
very nice work! adding comments on code organization but also on file organization
Collaborator
felipemadero
left a comment
felipemadero
left a comment
There was a problem hiding this comment.
Almost ready. Please try to fix the cycle and also move AvalancheGoVersionSettings related stuff to pkg/dependencies, and for the moment leave the prompting only in pkg/node
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was made in light of past incidents:
This PR ensures that users won't encounter errors if these incidents occur again in the future, and won't need to update their CLI version to resolve the issue.
The latest versions of AvalancheGo, Subnet EVM and other dependencies (ICM coming after this PR) will be defined in https://raw.githubusercontent.com/ava-labs/avalanche-cli/main/versions/latest.json. CLI will always use these dependencies' versions as default.
If a new version of a dependency such as AvalancheGo is released, we will first test the e2e flow to ensure that CLI still works with the new dependency. Once we have verified it, the AvalancheGo version will be updated in https://raw.githubusercontent.com/ava-labs/avalanche-cli/main/versions/latest.json.
An additional PR is needed to highlight the minimum version of dependency that can be used on each network (e.g. currently minimum release version for AvalancheGo in Fuji is v1.13.0-fuji and v1.13.0 in mainnet) -> Issue #2731