Conversation
sukantoraymond
requested review from
cwend-ava,
jasonatran,
learyce and
meaghanfitzgerald
Tonix517
approved these changes
Apr 7, 2025
| release: | ||
| needs: [lint, unit_test] | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
any specific reason to use this version?
Contributor
Author
There was a problem hiding this comment.
Enables CLI binary compatibility with 22.04 ubuntu. It is still compatible with 24.04.
If we build CLI on 24.04, users won't be able to install CLI binary on ubuntu 22.04
Contributor
Author
There was a problem hiding this comment.
ubuntu@ip-172-31-29-94:~$ /home/ubuntu/bin/avalanche --version
avalanche version 1.8.9-rc4
ubuntu@ip-172-31-29-94:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 22.04.5 LTS
Release: 22.04
Codename: jammy
Contributor
Author
There was a problem hiding this comment.
ubuntu@ip-172-31-16-118:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 24.04.2 LTS
Release: 24.04
Codename: noble
ubuntu@ip-172-31-16-118:~$ /home/ubuntu/bin/avalanche --version
avalanche version 1.8.9-rc4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2723
Enables CLI binary compatibility with 22.04 ubuntu. It is still compatible with 24.04.
If we build CLI on 24.04, users won't be able to install CLI binary on ubuntu 22.04