Skip to content

add error boolean to metrics, together with some renamings #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felipemadero merged 2 commits into from
Apr 7, 2025
Merged

add error boolean to metrics, together with some renamings #2727

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
915a35b
add error boolean to metrics, together with some renamings
felipemadero Apr 7, 2025
98bcbf3
address jtc req
felipemadero Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,16 @@ func trackMetrics(app *application.Avalanche, flags map[string]string, cmdErr er

telemetryProperties := make(map[string]interface{})
telemetryProperties["command"] = app.Cmd.CommandPath()
telemetryProperties["version"] = version
telemetryProperties["cli_version"] = version
telemetryProperties["os"] = runtime.GOOS
telemetryProperties["error"] = ""
telemetryProperties["was_successful"] = true
telemetryProperties["error_msg"] = ""
if cmdErr != nil {
telemetryProperties["error"] = cmdErr.Error()
telemetryProperties["was_successful"] = false
telemetryProperties["error_msg"] = cmdErr.Error()
}
insideCodespace := utils.InsideCodespace()
telemetryProperties["insideCodespace"] = insideCodespace
telemetryProperties["is_inside_codespace"] = insideCodespace
if insideCodespace {
codespaceName := os.Getenv(constants.CodespaceNameEnvVar)
telemetryProperties["codespace"] = codespaceName
Expand Down
Loading