Skip to content

Fix mainnet key error msg #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukantoraymond merged 2 commits into from
Apr 8, 2025
Merged

Fix mainnet key error msg #2729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9256f53
fix mainnet key error msg
sukantoraymond Apr 8, 2025
4aa9338
update err msg
sukantoraymond Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions pkg/keychain/keychain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ const (

var (
ErrMutuallyExlusiveKeySource = errors.New("key source flags --key, --ewoq, --ledger/--ledger-addrs are mutually exclusive")
ErrStoredKeyOrEwoqOnMainnet = errors.New("key sources --key, --ewoq are not available for mainnet operations")
ErrStoredKeyOnMainnet = errors.New("--key flag is not supported for mainnet operations, please use ledger instead")
ErrNonEwoqKeyOnMainnet = errors.New("key source --ewoq is not available for mainnet operations")
Copy link
Collaborator

@felipemadero felipemadero Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also advice to use ledger here

ErrNonEwoqKeyOnDevnet = errors.New("key source --ewoq is the only one available for devnet operations")
ErrEwoqKeyOnFuji = errors.New("key source --ewoq is not available for fuji operations")
)
Expand Down Expand Up @@ -157,8 +158,11 @@ func GetKeychainFromCmdLineFlags(
}
case network.Kind == models.Mainnet:
// mainnet requires ledger usage
if keyName != "" || useEwoq {
return nil, ErrStoredKeyOrEwoqOnMainnet
if keyName != "" {
return nil, ErrStoredKeyOnMainnet
}
if useEwoq {
return nil, ErrNonEwoqKeyOnMainnet
}
useLedger = true
}
Expand Down
Loading