at ictt, sleep between approve and add collateral, to avoid issues due to connecting to different API nodes#2735
Merged
sukantoraymond merged 1 commit intomainfrom Apr 30, 2025
Conversation
to connecting to different API nodes
felipemadero
requested review from
Tonix517,
artemanosov,
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
sukantoraymond
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #2721
How this works
Adds a wait of 5 secs between ERC20 spent approval and add the collateral to the Home. This
to avoid issues for hitting another outdated API node on the second operation.
How this was tested
ictt deploy executions on fuji
How is this documented