[DPTN-1569] Fixing validate earliest ts no upcoming UT#2748
Merged
felipemadero merged 1 commit intomainfrom Apr 17, 2025
Merged
[DPTN-1569] Fixing validate earliest ts no upcoming UT#2748felipemadero merged 1 commit intomainfrom
felipemadero merged 1 commit intomainfrom
Conversation
Tonix517
requested review from
artemanosov,
cwend-ava,
meaghanfitzgerald and
sukantoraymond
artemanosov
approved these changes
Apr 16, 2025
felipemadero
approved these changes
Apr 17, 2025
Collaborator
|
Nice! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Time waiting was called at wrong step of the UT, and it may fail the condition at the line below when block timestamp is at the same second of
time.Now():https://github.com/ava-labs/avalanche-cli/blob/main/cmd/blockchaincmd/upgradecmd/apply.go#L492
How this works
How this was tested
./scripts/unit_test.shHow is this documented