Deploy flags e2e #2755
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| { | ||
|
Collaborator
There was a problem hiding this comment. I like this cmd tree. probably this can have a default name, like test_table.json |
||
| "globalFlags": { | ||
| "local": true, | ||
| "skip-icm-deploy": true, | ||
| "skip-update-check": true | ||
| }, | ||
| "happyPath": [ | ||
| { | ||
| "name": "local deploy default", | ||
| "flags": {}, | ||
| "expectedContain": [ | ||
| "L1 is successfully deployed on Local Network" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "local deploy and use provided subnet id", | ||
| "flags": { | ||
| "subnet-id": "" | ||
| }, | ||
| "expectedContain": [ | ||
| "Deploying into pre-existent subnet ID", | ||
| "CreateChainTx fee", | ||
| "ConvertSubnetToL1Tx fee", | ||
| "L1 is successfully deployed on Local Network" | ||
| ], | ||
| "expectedNotContain": [ | ||
| "CreateSubnetTx fee" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "local deploy using provided avalanchego path in flag", | ||
| "flags": { | ||
| "avalanchego-path": "tests/e2e/assets/avalanchego" | ||
| }, | ||
| "expectedContain": [ | ||
| "AvalancheGo path: {avalanchego-path}" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "local deploy convert only", | ||
| "flags": { | ||
| "convert-only": true | ||
| }, | ||
| "expectedContain": [ | ||
| "To finish conversion to sovereign L1, create the corresponding Avalanche node(s) with the provided Node ID and BLS Info", | ||
| "Ensure that the P2P port is exposed and 'public-ip' config value is set", | ||
| "Once the Avalanche Node(s) are created and are tracking the blockchain, call `avalanche contract initValidatorManager testSubnet` to finish conversion to sovereign L1" | ||
| ], | ||
| "expectedNotContain": [ | ||
| "CreateChainTx fee", | ||
| "ConvertSubnetToL1Tx fee", | ||
| "L1 is successfully deployed on Local Network" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "local deploy using provided avalanchego path in flag", | ||
| "flags": { | ||
| "num-bootstrap-validators": "" | ||
| } | ||
| }, | ||
| { | ||
| "name": "local deploy using provided avalanchego path in flag", | ||
| "flags": { | ||
| "balance": "" | ||
| } | ||
| }, | ||
| { | ||
| "name": "local deploy using provided avalanchego path in flag", | ||
| "flags": { | ||
| "num-local-nodes": "" | ||
| } | ||
| } | ||
| ], | ||
| "notHappyPath": [ | ||
| { | ||
| "name": "invalid_version", | ||
| "flags": { | ||
| "avalanchego-version": "invalid_version" | ||
| }, | ||
| "expectedError": "invalid version string" | ||
| }, | ||
| { | ||
| "name": "local deploy using invalid avalanchego path", | ||
| "flags": { | ||
| "avalanchego-path": "invalid_avago_path" | ||
| }, | ||
| "expectedError": "invalid version string" | ||
| }, | ||
| { | ||
| "name": "local deploy and use provided subnet id, but subnet id is invalid", | ||
| "flags": { | ||
| "subnet-id": "invalid_subnet_id" | ||
| }, | ||
| "expectedError": "invalid version string" | ||
| }, | ||
| { | ||
| "name": "invalid_version", | ||
| "flags": { | ||
| "use-local-machine": false | ||
| }, | ||
| "expectedError": "invalid version string" | ||
| }, | ||
| { | ||
| "name": "local deploy and generate node id", | ||
| "flags": { | ||
| "generate-node-id": true | ||
| }, | ||
| "expectedError": "invalid version string" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| // Copyright (C) 2024, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
|
|
||
| package deploy | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/ava-labs/avalanche-cli/tests/e2e/commandse2e" | ||
|
|
||
| "github.com/ava-labs/avalanche-cli/tests/e2e/commands" | ||
| ginkgo "github.com/onsi/ginkgo/v2" | ||
| "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| const ( | ||
| deployTestJSONPath = "tests/e2e/commandse2e/blockchain/deploy/deploy_tests.json" | ||
| subnetName = "testSubnet" | ||
| ) | ||
|
|
||
| var ( | ||
| config *commandse2e.TestJSONConfig | ||
| err error | ||
| ) | ||
|
|
||
| const ewoqEVMAddress = "0x8db97C7cEcE249c2b98bDC0226Cc4C2A57BF52FC" | ||
|
|
||
| var _ = ginkgo.Describe("[Blockchain Deploy Flags]", ginkgo.Ordered, func() { | ||
| _ = ginkgo.BeforeEach(func() { | ||
| // Create test subnet config | ||
| commands.CreateSubnetEvmConfigSOV(subnetName, ewoqEVMAddress, commands.PoA) | ||
|
Collaborator
There was a problem hiding this comment. maybe this should be added to the json spec (how to setup required env) |
||
|
|
||
| // Read test configuration | ||
| config, err = commandse2e.ReadTestConfig(deployTestJSONPath) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| }) | ||
|
|
||
| ginkgo.AfterEach(func() { | ||
| commands.CleanNetwork() | ||
| // Cleanup test subnet config | ||
| commands.DeleteSubnetConfig(subnetName) | ||
| }) | ||
| blockchainCmdArgs := []string{subnetName} | ||
|
Collaborator
There was a problem hiding this comment. this should belong to the json test case IMO |
||
| ginkgo.It("should successfully deploy a blockchain", func() { | ||
| // Run each happy path test case | ||
| for _, testCase := range config.HappyPath { | ||
| ginkgo.By(fmt.Sprintf("Running test case: %s", testCase.Name)) | ||
| output, err := commandse2e.TestCommandWithJSONConfig( | ||
| commandse2e.BlockchainCmd, | ||
| "deploy", | ||
|
Collaborator
There was a problem hiding this comment. this should be a constant on cmd/blockchaincmd/ |
||
| blockchainCmdArgs, | ||
| deployTestJSONPath, | ||
| &testCase, | ||
| ) | ||
| if len(testCase.ExpectedContain) > 0 { | ||
| for _, expectedOutput := range testCase.ExpectedContain { | ||
| gomega.Expect(output).Should(gomega.ContainSubstring(expectedOutput)) | ||
| } | ||
| } | ||
| if len(testCase.ExpectedNotContain) > 0 { | ||
| for _, expectedOutput := range testCase.ExpectedNotContain { | ||
| gomega.Expect(output).ShouldNot(gomega.ContainSubstring(expectedOutput)) | ||
| } | ||
| } | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| } | ||
| }) | ||
|
|
||
| ginkgo.It("should handle error cases", func() { | ||
| // Run each not happy path test case | ||
| for _, testCase := range config.NotHappyPath { | ||
| ginkgo.By(fmt.Sprintf("Running test case: %s", testCase.Name)) | ||
| _, err = commandse2e.TestCommandWithJSONConfig( | ||
| commandse2e.BlockchainCmd, | ||
| "deploy", | ||
| blockchainCmdArgs, | ||
| deployTestJSONPath, | ||
| &testCase, | ||
| ) | ||
| gomega.Expect(err).Should(gomega.HaveOccurred()) | ||
| } | ||
| }) | ||
| }) | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure we want to start modifying CI at this stage