Skip to content

Comments

nit#2777

Closed
felipemadero wants to merge 7 commits intoartem/create-initial-test-for-transfer-key-commandfrom
fm/create-initial-test-for-transfer-key-command
Closed

nit#2777
felipemadero wants to merge 7 commits intoartem/create-initial-test-for-transfer-key-commandfrom
fm/create-initial-test-for-transfer-key-command

Conversation

@felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented Apr 30, 2025 •
edited
Loading

Why this should be merged

Fixes two bugs that need solution for new key transfer e2e at #2776:

  • the relayer default key is not created when the l1 configuration uses a given genesis file. later on, the relayer deploy fails due to this
  • foundry CLI installation fails when XDG_CONFIG_HOME is set, and this happens on CI

How this works

  • the relayer default key now is created on demand, every time it is needed, in this case, during blockchain deploy
  • foundry CLI installation removes XDG_CONFIG_HOME environment var, so foundry is always installed where CLI expects (unless previously installed)

How this was tested

CI - local executions of ictt deploy and blockchain deploy

How is this documented

@felipemadero felipemadero requested a review from a team as a code owner April 30, 2025 01:03
@github-project-automation github-project-automation bot moved this to Backlog 🗄️ in avalanchego Apr 30, 2025
@felipemadero felipemadero marked this pull request as draft April 30, 2025 01:03
@felipemadero felipemadero changed the base branch from artem/create-initial-test-for-transfer-key-command to main April 30, 2025 03:11
@felipemadero felipemadero changed the base branch from main to artem/create-initial-test-for-transfer-key-command April 30, 2025 03:11
@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to Done ✅ in avalanchego Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@learyce learyce Awaiting requested review from learyce learyce was automatically assigned from ava-labs/tooling

@Tonix517 Tonix517 Awaiting requested review from Tonix517 Tonix517 was automatically assigned from ava-labs/tooling

@jasonatran jasonatran Awaiting requested review from jasonatran jasonatran was automatically assigned from ava-labs/tooling

@sukantoraymond sukantoraymond Awaiting requested review from sukantoraymond sukantoraymond was automatically assigned from ava-labs/tooling

@artemanosov artemanosov Awaiting requested review from artemanosov artemanosov was automatically assigned from ava-labs/tooling

@meaghanfitzgerald meaghanfitzgerald Awaiting requested review from meaghanfitzgerald meaghanfitzgerald was automatically assigned from ava-labs/tooling

@cwend-ava cwend-ava Awaiting requested review from cwend-ava cwend-ava was automatically assigned from ava-labs/tooling

Assignees

@felipemadero felipemadero

Labels

None yet

Projects

avalanchego
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@felipemadero