[DPTN-1653] Adding e2e test for local node start#2792
Closed
Conversation
Tonix517
requested review from
artemanosov,
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
felipemadero
reviewed
May 8, 2025
Collaborator
felipemadero
left a comment
felipemadero
left a comment
There was a problem hiding this comment.
please take into account testing the flags
| return runCmd(cmd, ExpectSuccess) | ||
| } | ||
|
|
||
| func NodeLocalStart(clusterName string) (string, error) { |
Collaborator
There was a problem hiding this comment.
start has a good amount of flags that can be tested
Tonix517
force-pushed
the
tonyz/add_e2e_node_local
branch
from
2afe7a2 to
87c17f6
Compare
Tonix517
force-pushed
the
tonyz/add_e2e_node_local
branch
from
87c17f6 to
8cda684
Compare
Collaborator
|
Closing as CLI is moving into maintenance mode. Thanks for the work on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
https://ava-labs.atlassian.net/browse/DPTN-1653
How this was tested
NOTE: will need to rebase when #2784 is merged.