Add e2e tests for icm deploy and sendMsg commands#2798
Conversation
artemanosov
requested review from
Tonix517,
cwend-ava,
jasonatran,
learyce,
meaghanfitzgerald and
sukantoraymond
artemanosov
changed the title
artemanosov
force-pushed
the
artem/add-e2e-tests-for-icm
branch
from
385649a to
6cd0ef3
Compare
artemanosov
force-pushed
the
artem/add-e2e-tests-for-icm
branch
from
6cd0ef3 to
d68bc95
Compare
|
Right now we have three commands that do the same thing:
Can we just keep one and remove two? |
i believe we can now remove teleporter. probably keep both interchain messenger and icm as an alias. |
|
|
||
| output, err := utils.TestCommand(utils.ICMCmd, "deploy", commandArguments, globalFlags, testFlags) | ||
| gomega.Expect(err).Should(gomega.BeNil()) | ||
| gomega.Expect(output). |
There was a problem hiding this comment.
do we want to trust CLI output? or instead try to find out at least that there are contracts at the expected locations?
not sure on this, just open question
There was a problem hiding this comment.
I think we should find out if there are contract in that location -> also good knowledge for us to have anyways
There was a problem hiding this comment.
How would we do that?
There was a problem hiding this comment.
@felipemadero are there functions we can implement to check if a contract exists in a blockchain?
There was a problem hiding this comment.
you can use ContractAlreadyDeployed from sdk/evm/evm.go
artemanosov
force-pushed
the
artem/add-e2e-tests-for-icm
branch
from
4cec5e0 to
4f39539
Compare
felipemadero
left a comment
felipemadero
left a comment
There was a problem hiding this comment.
LGTM. Much better if contracts are verified to be deployed directly on the L1. For messenger, it can also be checked that it is not deployed before
3 participants
Why this should be merged
How this works
How this was tested
How is this documented