Skip to content

Comments

use validator manager v2_0_0 as default#2821

Merged
felipemadero merged 15 commits intomainfrom
validator_manager_v2.0.0
Jun 2, 2025
Merged

use validator manager v2_0_0 as default#2821
felipemadero merged 15 commits intomainfrom
validator_manager_v2.0.0

Conversation

@felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented May 27, 2025

Why this should be merged

Closes #2629 #2640

Main difference with CLI 1.0.0 implementation:

  • On 1.0.0 there is only one validator manager, one proxy, one proxy admin, both for PoS and PoA cases. For PoA, the proxy, proxy admin, and manager are all set in genesis. For PoS, the proxy, proxy admin, validator messages lib and reward calculator are set in genesis, while the manager is deployed afterwards.
  • On 2.0.0, there is only one validator manager, one proxy and one proxy admin for PoA, but two proxies, two proxy admins, a validator manager, and a specialized validator manager for PoS. For PoA, the proxy, proxy admin, and manager are all set in genesis. For PoS, the two proxies, the two proxy admins, the validator messages lib and reward calculator are set in genesis, while the manager and the specialized managers are deployed afterwards. So, not always a manager is having a fixed address. But the proxies have.

Validator Manager Proxy Address: 0x0FEEDC0DE0000000000000000000000000000000 (PoA)
Specialized Manager Proxy Address: 0x100C0DE1C0FFEE00000000000000000000000000 (PoS)

For PoS, a Validator Manager Proxy Address is also present at the FEEDCODE address, but is not expected to be
typically accessed by the user.

How this works

How this was tested

How is this documented

@felipemadero felipemadero requested a review from a team as a code owner May 27, 2025 12:34
@felipemadero felipemadero marked this pull request as draft May 27, 2025 12:34
@felipemadero felipemadero changed the title replace acp99 contract naming with v2_0_0 use validator manager v2_0_0 as default May 27, 2025
@felipemadero felipemadero marked this pull request as ready for review May 30, 2025 16:28
Copy link

@Tonix517 Tonix517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to unblock merging - assuming all tests pass

@felipemadero felipemadero merged commit 81ec104 into main Jun 2, 2025
101 of 102 checks passed
@felipemadero felipemadero deleted the validator_manager_v2.0.0 branch June 2, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ACP-99

2 participants