Check that CLI is at least specified min version#2832
Merged
sukantoraymond merged 9 commits intomainfrom Jun 6, 2025
Merged
Conversation
sukantoraymond
requested review from
Tonix517,
artemanosov,
cwend-ava,
jasonatran,
learyce and
meaghanfitzgerald
Tonix517
approved these changes
Jun 5, 2025
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
Signed-off-by: sukantoraymond <rsukanto@umich.edu>
felipemadero
reviewed
Jun 6, 2025
pkg/version/min_cli_version.go
Outdated
|
|
||
| versionComparison := semver.Compare(version, minVersion) | ||
| if versionComparison == -1 { | ||
| return fmt.Errorf("CLI version is required to be at least %s, current CLI version is %s, please upgrade CLI by calling `curl -sSfL https://raw.githubusercontent.com/ava-labs/avalanche-cli/main/scripts/install.sh | sh -s`", minVersion, version) |
Collaborator
There was a problem hiding this comment.
can you also add avalanche update to the upgrade instructions?
Collaborator
There was a problem hiding this comment.
this as the first option, and the curl as second one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When CLI has higher min version specified
This is required because if we update our schema for dependency versioning, CLI will need to know how to process these changes to function.