Skip to content

Conversation

DracoLi
Copy link
Contributor

@DracoLi DracoLi commented Jul 28, 2025

Why this should be merged

Add an BlockDatabase interface to database package. This will be used by the VMs to integrate x/blockdb, starting with coreth (see POC PR).

How this works

Interface added to database/database.go

How this was tested

Need to be documented in RELEASES.md?

No

@joshua-kim joshua-kim moved this to Backlog 🧊 in avalanchego Aug 18, 2025
Base automatically changed from dl/blockdb to master August 19, 2025 16:18
@DracoLi DracoLi force-pushed the dl/blockdb-interface branch from d1c75ba to dfc9873 Compare August 22, 2025 15:56
@DracoLi DracoLi marked this pull request as ready for review August 22, 2025 16:17
@Copilot Copilot AI review requested due to automatic review settings August 22, 2025 16:17
@DracoLi DracoLi requested review from a team and maru-ava and removed request for a team August 22, 2025 16:18
Copilot

This comment was marked as outdated.

@DracoLi DracoLi requested a review from Copilot August 22, 2025 17:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new BlockDatabase interface to the database package to provide a standardized API for blockchain block storage and retrieval operations. This interface will enable VM integration with the x/blockdb component.

  • Introduces BlockDatabase interface with methods for block CRUD operations
  • Adds inspection and resource management capabilities to the interface

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Draco <[email protected]>
@maru-ava
Copy link
Contributor

Does this have a target consumer (i.e. simplex)?

@DracoLi
Copy link
Contributor Author

DracoLi commented Aug 25, 2025

@maru-ava yes, coreth will be using this first. I'm working on a PR to switch it to use blockdb.

@maru-ava
Copy link
Contributor

@maru-ava yes, coreth will be using this first. I'm working on a PR to switch it to use blockdb.

Maybe link the coreth PR that depends on this PR so that the intention is clear?

@DracoLi DracoLi requested a review from joshua-kim September 4, 2025 18:09
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Draco <[email protected]>
@StephenButtolph StephenButtolph changed the title Add BlockDatabase interface to database Add HeightIndex interface to database Sep 22, 2025
@StephenButtolph StephenButtolph added this pull request to the merge queue Sep 22, 2025
Merged via the queue into master with commit 7978eea Sep 22, 2025
35 checks passed
@StephenButtolph StephenButtolph deleted the dl/blockdb-interface branch September 22, 2025 19:25
@github-project-automation github-project-automation bot moved this from Backlog 🧊 to Done 🎉 in avalanchego Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants