-
Notifications
You must be signed in to change notification settings - Fork 809
Add HeightIndex interface to database #4133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d1c75ba
to
dfc9873
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new BlockDatabase
interface to the database package to provide a standardized API for blockchain block storage and retrieval operations. This interface will enable VM integration with the x/blockdb component.
- Introduces
BlockDatabase
interface with methods for block CRUD operations - Adds inspection and resource management capabilities to the interface
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]> Signed-off-by: Draco <[email protected]>
Does this have a target consumer (i.e. simplex)? |
@maru-ava yes, coreth will be using this first. I'm working on a PR to switch it to use blockdb. |
Maybe link the coreth PR that depends on this PR so that the intention is clear? |
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Draco <[email protected]>
Why this should be merged
Add an
BlockDatabase
interface todatabase
package. This will be used by the VMs to integrate x/blockdb, starting with coreth (see POC PR).How this works
Interface added to
database/database.go
How this was tested
Need to be documented in RELEASES.md?
No