Skip to content

Conversation

DracoLi
Copy link
Contributor

@DracoLi DracoLi commented Sep 25, 2025

Why this should be merged

Enable running reexecution tests with blockdb enabled for workflow runs.

The config is added in ava-labs/coreth#1189

How this works

Enables block database for the c-chain. Block database is disabled by default.

How this was tested

Need to be documented in RELEASES.md?

@Copilot Copilot AI review requested due to automatic review settings September 25, 2025 14:31
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds blockdb configuration to C-chain reexecution tests to enable running tests with block database functionality. The change enables testing of block database features that are disabled by default.

  • Adds a new "blockdb" configuration entry to the test configurations map
  • Enables block database functionality specifically for reexecution test scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@DracoLi DracoLi changed the title feat: add blockdb config to reexecution tests test: add blockdb config to reexecution tests Sep 25, 2025
@aaronbuchwald
Copy link
Collaborator

What's the intended path for this PR on the C-Chain?

Fine to add, but I would think we can easily run the re-execution test on a PR to evaluate its performance and decide based on that if we want to pursue it rather than merging it upfront. If the lifecycle of integrating / optimizing it will be longer, then merging support for this config makes sense to me though.

Could also add support for new configs by following up on #4108 to support passing arbitrary JSON along with a name to use for the config.

@DracoLi
Copy link
Contributor Author

DracoLi commented Sep 25, 2025

@aaronbuchwald
yeah i agree - I don't think i'll need to run this very often right now. I'll close this PR and instead run it locally or on a box for now.
I think #4108 is a better improvement so we won't need this once that is done.

@DracoLi DracoLi closed this Sep 25, 2025
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Sep 25, 2025
@aaronbuchwald
Copy link
Collaborator

Sounds good, if you find it easiest to re-trigger by pushing to a PR where the config is supported, I'd just open to a draft PR. I am still working on migrating from executing the initial phase of the chain to a much later point (33m) and then to near tip.

To test the blockdb changes, you may want to re-generate that state from scratch, so that the database is not incorrectly much larger due to having written blocks to the original format up to that checkpoint.

@aaronbuchwald
Copy link
Collaborator

If you want to generate your own checkpoints, I vibe coded this script that I decided against checking in to AvalancheGo: https://gist.github.com/aaronbuchwald/3d222f657c926ebfef44098beea77ab2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants