fix: skip TestConflictingImportTxsAcrossBlocks if using Firewood#5018
Merged
fix: skip TestConflictingImportTxsAcrossBlocks if using Firewood#5018
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses test flakiness observed with the TestConflictingImportTxsAcrossBlocks test when using Firewood with Go 1.25, following the same pattern established in PR #5001 for handling Firewood-related test failures.
Changes:
- Add conditional test skip for
testConflictingImportTxswhen using the Firewood storage scheme - Import
customrawdbpackage to access theFirewoodSchemeconstant - Reference GitHub issue #1679 tracking the underlying Firewood stack corruption issue
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Elvis339
approved these changes
Feb 23, 2026
alarso16
approved these changes
Feb 23, 2026
maru-ava
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Similar to #5001, bumping the go version to 1.25 has resulted in this additional test flake: https://github.com/ava-labs/avalanchego/actions/runs/22294384926/job/64487963219?pr=4942#step:4:20738. This flake was observed with the test
TestConflictingImportTxsAcrossBlocks.How this works
Skips
TestConflictingImportTxsAcrossBlocksif using Firewood.How this was tested
CI
Need to be documented in RELEASES.md?
No