Skip to content

fix(approval): apply new design for delegator/validator approval screen#770

Open
frichards wants to merge 6 commits intomainfrom
cp-12846-update-vm-module
Open

fix(approval): apply new design for delegator/validator approval screen#770
frichards wants to merge 6 commits intomainfrom
cp-12846-update-vm-module

Conversation

@frichards
Copy link
Contributor

@frichards frichards commented Feb 12, 2026

Description

Ticket: https://ava-labs.atlassian.net/browse/CP-12846

Changes

  1. Update the vm-modules with new item details.
  2. handle simple item details to handle simpler design for address item.

Testing

please trigger both delegator and validator approval screens.

Screenshots:

Screenshot 2026-02-16 at 09 21 52 Screenshot 2026-02-16 at 09 21 34

Checklist for the author

Tick each of them when done or if not applicable.

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

meeh0w
meeh0w previously approved these changes Feb 13, 2026
Comment on lines 52 to 63
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is this necessary? It's a bit weird that we're handling the same detail type differently, maybe it's just a UX Team's oversight?

Image

vs

Image

It seems that if we just accepted From as the label, we could get rid of this added complexity here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to the UX team.
They wanted the label to the account name and the value to be the address.
But I can talk to them again.

meeh0w
meeh0w previously approved these changes Feb 16, 2026
Copy link
Member

@meeh0w meeh0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump the VM Modules version and have it dev tested :)

@frichards frichards marked this pull request as ready for review February 16, 2026 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments