New QA - test updating app icon and fix some failures #3652
Merged
Conversation
eunjisong
requested review from
B0Y3R-AVA,
alexnicolae-ava,
atn4z7,
bogdandobritoiu,
onghwan and
ruijialin-avalabs
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new Appium E2E coverage for changing/restoring the app icon and includes a set of test-stability fixes across Appium page objects/locators plus a few UI testID/accessibility adjustments to support automation.
Changes:
- Add new Appium spec for verifying default app icon, changing it, and restoring it.
- Update Appium page objects/locators and interaction helpers to reduce flakiness (selector updates, onboarding dismissal, bottom sheet handling, click vs tap).
- Adjust several UI components’
testID/accessibility behavior to improve automated test targeting.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/k2-alpine/src/components/GroupList/GroupList.tsx | Changes right-value testID strategy for GroupList rows. |
| packages/k2-alpine/src/components/FiatAmountInputWidget/FiatAmountInput.tsx | Tweaks accessibility flags and removes accessibilityLabel from fiat amount input. |
| packages/core-mobile/e2e-appium/wdio.conf.ts | Updates local iOS app binary path used by Appium runs. |
| packages/core-mobile/e2e-appium/specs/transactions/earn/borrow.spec.ts | Adds a deposit step before borrowing. |
| packages/core-mobile/e2e-appium/specs/settings/appIcon.spec.ts | New Appium spec covering app icon default/change/restore. |
| packages/core-mobile/e2e-appium/pages/transactions.page.ts | Updates selectors and improves onboarding/bottom-sheet handling; fixes fiat amount input selector usage. |
| packages/core-mobile/e2e-appium/pages/settings.page.ts | Adds App Icon navigation/verification helpers and random icon selection. |
| packages/core-mobile/e2e-appium/pages/portfolio.page.ts | Normalizes token IDs and adds refresh before token-detail verification. |
| packages/core-mobile/e2e-appium/pages/commonEls.page.ts | Adds right-value selector helper and simplifies dropdown item selection. |
| packages/core-mobile/e2e-appium/locators/transactions.loc.ts | Updates review-stake title text; adds fiat amount input locator. |
| packages/core-mobile/e2e-appium/locators/settings.loc.ts | Adds App Icon-related strings/locators. |
| packages/core-mobile/e2e-appium/helpers/actions.ts | Changes tap() implementation to use click() for elements. |
| packages/core-mobile/app/new/features/portfolio/assets/components/TokenListView.tsx | Moves balance testID placement within list item. |
| packages/core-mobile/app/new/features/portfolio/assets/components/TokenGridView.tsx | Moves balance testID placement within grid item. |
| packages/core-mobile/app/new/features/defiMarket/components/repay/RepaySelectAmountFormBase.tsx | Adds conditional testID for enabled/disabled Next button. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
packages/k2-alpine/src/components/FiatAmountInputWidget/FiatAmountInput.tsx
Show resolved
Hide resolved
onghwan
approved these changes
Mar 17, 2026
atn4z7
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description