Conversation
atn4z7
approved these changes
Mar 17, 2026
ruijialin-avalabs
approved these changes
Mar 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ScrollScreen’s footer measurement and scroll padding logic to prevent footer content overlapping the scrollable content, especially when using sticky footers with keyboard avoidance.
Changes:
- Replace
measure()-based footer height calculation with anonLayoutcallback. - Move footer height storage from Reanimated
useSharedValueto ReactuseStateto trigger re-renders. - Compute
contentContainerStyle.paddingBottomdynamically using the measured footer height instead of a hardcoded constant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-13638
ScrollScreenfooter content overlapping theScrollViewcontent areauseRef+useLayoutEffect+measurefooter height measurement withonLayoutcallbackuseSharedValuewithuseStatefor footer height socontentContainerStyle.paddingBottomandextraKeyboardSpaceproperly re-render when the footer is measuredpaddingBottombased on actual footer height instead of a hardcoded32Root cause: The previous implementation used
footerRef.current.measure()insideuseLayoutEffect, which has known timing issues in React Native and could return stale/zero values. Additionally,footerHeightwas a ReanimateduseSharedValue, which doesn't trigger React re-renders — so even when the height was measured, theScrollView'scontentContainerStylenever updated.Screenshots/Videos
ScreenRecording_03-17-2026.15-05-31_1.MP4
Testing
iOS: 7764
Android: 7765
Testing
ScrollScreenwith arenderFooterprop (e.g. Approval screen, DeFi withdraw screen)shouldAvoidKeyboardenabled — tap an input, verify the footer sticks above the keyboard and content padding adjusts correctlydisableStickyFooter— verify the footer remains at the bottom and content padding uses safe area insetsrenderFooter— verifypaddingBottomfalls back toinsets.bottom + 24Checklist