perf: Use Firewood's Revision

Author: alarso16

core/txpool/legacypool/legacypool.go

@@ -446,6 +446,11 @@ func (pool *LegacyPool) Close() error {
 	if pool.journal != nil {
 		pool.journal.close()
 	}
+
+	// remove all references to state to allow GC to reclaim memory
+	pool.pendingNonces = nil
+	pool.currentState = nil
+
 	log.Info("Transaction pool stopped")
 	return nil
 }

triedb/firewood/database.go

@@ -482,16 +482,17 @@ func (db *Database) removeProposalFromMap(pCtx *ProposalContext) {
 // Reader retrieves a node reader belonging to the given state root.
 // An error will be returned if the requested state is not available.
 func (db *Database) Reader(root common.Hash) (database.Reader, error) {
-	if _, err := db.fwDisk.GetFromRoot(root.Bytes(), []byte{}); err != nil {
+	revision, err := db.fwDisk.Revision(root.Bytes())
+	if err != nil {
 		return nil, fmt.Errorf("firewood: unable to retrieve from root %s: %w", root.Hex(), err)
 	}
-	return &reader{db: db, root: root}, nil
+	fmt.Printf("Firewood Reader created at %p\n", revision)
+	return &reader{revision: revision}, nil
 }
 
 // reader is a state reader of Database which implements the Reader interface.
 type reader struct {
-	db   *Database
-	root common.Hash // The root of the state this reader is reading.
+	revision *ffi.Revision
 }
 
 // Node retrieves the trie node with the given node hash. No error will be
@@ -500,7 +501,7 @@ func (reader *reader) Node(_ common.Hash, path []byte, _ common.Hash) ([]byte, e
 	// This function relies on Firewood's internal locking to ensure concurrent reads are safe.
 	// This is safe even if a proposal is being committed concurrently.
 	start := time.Now()
-	result, err := reader.db.fwDisk.GetFromRoot(reader.root.Bytes(), path)
+	result, err := reader.revision.Get(path)
 	if metrics.EnabledExpensive {
 		ffiReadCount.Inc(1)
 		ffiReadTimer.Inc(time.Since(start).Milliseconds())