style: enable gosec linter #1202
Open
+74
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
alarso16
reviewed
Sep 17, 2025
ceyonur
reviewed
Sep 18, 2025
alarso16
reviewed
Sep 22, 2025
alarso16
reviewed
Sep 24, 2025
JonathanOppenheimer
force-pushed
the
lint-enable-gosec
branch
from
99dafde to
d960769
Compare
Signed-off-by: Jonathan Oppenheimer <[email protected]>
alarso16
reviewed
Oct 8, 2025
utils/rand/rand.go
Outdated
| "math" | ||
| ) | ||
|
|
||
| func SecureFloat64() float64 { |
There was a problem hiding this comment.
This is somewhat terrifying. I don't know how this works. Not sure I can really review this
There was a problem hiding this comment.
I have updated the implementation to this: https://brandur.org/fragments/crypto-rand-float64.
Only issue is now copyright. Is this acceptable? I added attribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR works towards completing #1144.