style: enable errcheck linter #1203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanOppenheimer
requested review from
a team and
alarso16
as code owners
alarso16
previously requested changes
Sep 10, 2025
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
I resolved these. |
There was a problem hiding this comment.
These trie error handling changes are lowkey terrifying... Need to dig into these to make sure they are safe.
There was a problem hiding this comment.
Update: not scary at all. An error will only be returned if not called with HashDB (because geth is a nightmare)
Co-authored-by: Stephen Buttolph <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
alarso16
previously requested changes
Sep 15, 2025
Co-authored-by: Austin Larson <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]>
alarso16
reviewed
Sep 22, 2025
alarso16
reviewed
Sep 25, 2025
…/lint-enable-errcheck
alarso16
previously requested changes
Oct 8, 2025
There was a problem hiding this comment.
Update: not scary at all. An error will only be returned if not called with HashDB (because geth is a nightmare)
alarso16
reviewed
Oct 8, 2025
alarso16
reviewed
Oct 8, 2025
alarso16
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR works towards completing #1144.