This repository was archived by the owner on Nov 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 160
fix: database inspection #1245
Merged
Merged
fix: database inspection #1245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
reviewed
Sep 19, 2025
ceyonur
approved these changes
Sep 19, 2025
Collaborator
ceyonur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an optional nit
Co-authored-by: Ceyhun Onur <[email protected]> Signed-off-by: rodrigo <[email protected]>
ARR4N
approved these changes
Sep 19, 2025
Collaborator
ARR4N
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending the suggestion by @ceyonur
Closed
powerslider
approved these changes
Oct 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As mentioned in #1137, starting an instance of Coreth with database inspection enabled will fail as Coreth doesn't use freezers but upstream code (Libevm) previously assumed so. With ava-labs/libevm#220 now available, we can now skip freezer inspection.
How this works
Adds an option to skip freezer inspection when inspecting the database.
How this was tested
Added a UT + upstream test: https://github.com/ava-labs/libevm/blob/ba9ab538b90236c480c412c54816717f3eb501e9/core/rawdb/database.libevm_test.go#L25-L49
Need to be documented?
Not sure
Need to update RELEASES.md?
Not sure