Skip to content

Conversation

RodrigoVillar
Copy link
Contributor

@RodrigoVillar RodrigoVillar commented Sep 19, 2025

Why this should be merged

As mentioned in #1137, starting an instance of Coreth with database inspection enabled will fail as Coreth doesn't use freezers but upstream code (Libevm) previously assumed so. With ava-labs/libevm#220 now available, we can now skip freezer inspection.

How this works

Adds an option to skip freezer inspection when inspecting the database.

How this was tested

Added a UT + upstream test: https://github.com/ava-labs/libevm/blob/ba9ab538b90236c480c412c54816717f3eb501e9/core/rawdb/database.libevm_test.go#L25-L49

Need to be documented?

Not sure

Need to update RELEASES.md?

Not sure

@RodrigoVillar RodrigoVillar self-assigned this Sep 19, 2025
@RodrigoVillar RodrigoVillar marked this pull request as ready for review September 19, 2025 15:19
@RodrigoVillar RodrigoVillar requested a review from a team as a code owner September 19, 2025 15:19
Copy link
Collaborator

@ceyonur ceyonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just an optional nit

Co-authored-by: Ceyhun Onur <[email protected]>
Signed-off-by: rodrigo <[email protected]>
Copy link
Collaborator

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving pending the suggestion by @ceyonur

@RodrigoVillar RodrigoVillar linked an issue Oct 10, 2025 that may be closed by this pull request
@ARR4N ARR4N added this pull request to the merge queue Oct 10, 2025
Merged via the queue into master with commit a966839 Oct 10, 2025
9 checks passed
@ARR4N ARR4N deleted the rodrigo/fix-inspect-databases branch October 10, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: inspect databases

4 participants