-
Notifications
You must be signed in to change notification settings - Fork 158
chore: remove deprecated genesis types #1315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: remove deprecated genesis types #1315
Conversation
This is just upstream |
I can not remove the two variables if you'd like, but not using See this PR: https://github.com/ava-labs/subnet-evm/pull/1152/files#diff-22ed370c0d46b80df36e872f67c920f4483e0d82611c3544f870b11bce246f0a, and how I assume this one was just missed. (I have a PR in subnet-evm open for the same thing, and I think more |
@ARR4N I have removed the removal of the types, so as to not increase the difference with geth. |
Looks like you forgot to push |
oops! fixed |
Why this should be merged
These types are explicitly deprecated and just serve as a type alias. However we maintain them to reduce the diff with geth.
How this was tested
Existing UTs
Need to be documented?
No
Need to update RELEASES.md?
No