Skip to content

Conversation

JonathanOppenheimer
Copy link
Member

@JonathanOppenheimer JonathanOppenheimer commented Oct 2, 2025

Why this should be merged

These types are explicitly deprecated and just serve as a type alias. However we maintain them to reduce the diff with geth.

How this was tested

Existing UTs

Need to be documented?

No

Need to update RELEASES.md?

No

@ARR4N
Copy link
Collaborator

ARR4N commented Oct 2, 2025

This is just upstream geth code. Although it's unlikely that core will undergo another geth sync given SAE, I still don't think we should be adding further diffs.

@JonathanOppenheimer
Copy link
Member Author

JonathanOppenheimer commented Oct 2, 2025

This is just upstream geth code. Although it's unlikely that core will undergo another geth sync given SAE, I still don't think we should be adding further diffs.

I can not remove the two variables if you'd like, but not using types. is actually a farther diff from upstream geth code, AFAIK (and we use libevm with types.!)

See this PR: https://github.com/ava-labs/subnet-evm/pull/1152/files#diff-22ed370c0d46b80df36e872f67c920f4483e0d82611c3544f870b11bce246f0a, and how core.GenesisAlloc{ was replaced with types.GenesisAlloc

I assume this one was just missed. (I have a PR in subnet-evm open for the same thing, and I think more GenesisAlloc were missed)

@JonathanOppenheimer
Copy link
Member Author

@ARR4N I have removed the removal of the types, so as to not increase the difference with geth.

@michaelkaplan13
Copy link
Contributor

@ARR4N I have removed the removal of the types, so as to not increase the difference with geth.

Looks like you forgot to push

@JonathanOppenheimer
Copy link
Member Author

@ARR4N I have removed the removal of the types, so as to not increase the difference with geth.

Looks like you forgot to push

oops! fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants