-
Notifications
You must be signed in to change notification settings - Fork 158
chore(customrawdb): delete customrawdb package and switch to avalanchego imports #1319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ego imports resolves #1302 Signed-off-by: Tsvetan Dimitrov ([email protected])
e96e06d
to
faad5d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Difference in this repository looks good - IMO, should not be merged until there's master commit that can be referenced.
"github.com/ava-labs/libevm/trie" | ||
"github.com/ava-labs/libevm/triedb" | ||
|
||
mrand "math/rand" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, goimports
or gci
lint error.
Added a DO NOT MERGE label until ava-labs/avalanchego#4387 is merged. |
I will review post AvalancheGo merger and when this PR is updated! |
Why this should be merged
Check #1302
How this works
plugin/evm/customrawdb
.github.com/ava-labs/avalanchego/vms/evm/sync/customrawdb
import instead.How this was tested
successful build
Need to be documented?
no
Need to update RELEASES.md?
no
resolves #1302
Signed-off-by: Tsvetan Dimitrov ([email protected])