feat(internal/ethapi): historical-proof-query-window option for archive nodes eth_getProof
#719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
commented
Dec 26, 2024
qdm12
force-pushed
the
qdm12/historical-proofs-options
branch
from
6deaa8a to
bdfbbcd
Compare
qdm12
force-pushed
the
qdm12/historical-proofs-options
branch
2 times, most recently
from
1d1a1a1 to
3a7ba07
Compare
darioush
reviewed
Dec 27, 2024
darioush
reviewed
Dec 30, 2024
ceyonur
reviewed
Jan 1, 2025
qdm12
force-pushed
the
qdm12/historical-proofs-options
branch
4 times, most recently
from
5920832 to
534a73e
Compare
qdm12
commented
Jan 3, 2025
qdm12
force-pushed
the
qdm12/historical-proofs-options
branch
from
6cea7d1 to
8a89462
Compare
darioush
reviewed
Jan 6, 2025
qdm12
changed the title
historical-proofs and recent-blocks-window options for GetProofshistorical-state-query-window option for GetProofs
qdm12
force-pushed
the
qdm12/historical-proofs-options
branch
2 times, most recently
from
76d1f74 to
8948854
Compare
qdm12
commented
Jan 8, 2025
qdm12
force-pushed
the
qdm12/historical-proofs-options
branch
from
8948854 to
6e83e97
Compare
darioush
reviewed
Jan 8, 2025
darioush
previously approved these changes
Jan 9, 2025
qdm12
changed the title
historical-state-query-window option for GetProofshistorical-proof-query-window option for archive nodes get_proof
qdm12
changed the title
historical-proof-query-window option for archive nodes get_proofhistorical-proof-query-window option for archive nodes eth_getProof
- Dynamic default depending if pruning is true or false - Replace `historical-proofs` with `historical-state-query-window` set to `0` to allow any block number state query - Replace `recent-blocks-window` with `historical-state-query-window` which is only applicable for archive nodes - For non-archive nodes, `historical-state-query-window` defaults to the tip buffer size of 32 - Set eth default HistoricalStateQueryWindow to 43200 (is this necessary?) - Export core.tipBufferSize - Update release notes
- remove the need to modify config after reading it - remove the need to import core from config package - core.TipBufferSize is used if running in non-archive mode within the function `isHistoricalStateQueryAllowed`
- rename `defaultBlocksWindow` -> `defaultHistoricalProofQueryWindow` - Chain calls with `s.b.LastAcceptedBlock().NumberU64()`
qdm12
force-pushed
the
qdm12/historical-proofs-options
branch
from
1633751 to
d09eabb
Compare
ceyonur
approved these changes
Jan 13, 2025
darioush
approved these changes
Jan 13, 2025
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 13, 2025
…blocks - default behavior for pruning mode to reject blocks before the 32 blocks preceding the last accepted block - default behavior for archive mode to reject blocks before ~24h worth of blocks preceding the last accepted block - archive mode new option `historical-proof-query-window` to customize the blocks window, or set it to 0 to accept any block number See ava-labs/coreth#719
node-druidx56y
added a commit
to node-druidx56y/subnet-evm
that referenced
this pull request
Sep 28, 2025
…blocks - default behavior for pruning mode to reject blocks before the 32 blocks preceding the last accepted block - default behavior for archive mode to reject blocks before ~24h worth of blocks preceding the last accepted block - archive mode new option `historical-proof-query-window` to customize the blocks window, or set it to 0 to accept any block number See ava-labs/coreth#719
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Resolves #714
How this works
historical-proof-query-windowfor archive nodes only which:historical-proof-query-window43200to accept get proof queries for blocks dating from the last 24 hours approximately0to accept any block number get proof queryHow this was tested
TestBlockChainAPI_stateQueryBlockNumberAllowedNeed to be documented?
Need to update RELEASES.md?