chore(core/types): remove Blocks's Timestamp() method
#749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
7f4bf55 to
ec26332
Compare
darioush
reviewed
Jan 16, 2025
This comment was marked as outdated.
This comment was marked as outdated.
qdm12
changed the title
Timestamp() method on Block typesTimestamp() method on core/types.Block
qdm12
changed the title
Timestamp() method on core/types.BlockBlocks's Timestamp() method
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
37cbc5c to
5d7b0c4
Compare
ceyonur
previously approved these changes
Jan 21, 2025
darioush
previously approved these changes
Jan 21, 2025
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
5d7b0c4 to
19f0c6b
Compare
darioush
previously approved these changes
Jan 21, 2025
qdm12
commented
Jan 22, 2025
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
2 times, most recently
from
940bb2a to
85ec7d0
Compare
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
01d201c to
b204317
Compare
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
2 times, most recently
from
1c393af to
395184d
Compare
qdm12
commented
Feb 6, 2025
- Define `core.BlockContext` implementing `contract.ConfigurationBlockContext` (same as subnet-evm) - Use `core.NewBlockContext` to convert `types.Block` and `types.Header` for calls to `core.ApplyUpgrades`
qdm12
force-pushed
the
qdm12/block-remove-timestamp
branch
from
395184d to
be07a4c
Compare
darioush
approved these changes
Feb 7, 2025
ceyonur
approved these changes
Feb 7, 2025
ARR4N
pushed a commit
that referenced
this pull request
Mar 10, 2025
- Define `core.BlockContext` implementing `contract.ConfigurationBlockContext` (same as subnet-evm) - Use `core.NewBlockContext` to convert `types.Block` and `types.Header` for calls to `core.ApplyUpgrades`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
In
core/types, theBlockmethodTimestampdoes the same as the methodTimeand is not present upstream (this causes small difficulties in #750)How this works
core.BlockContextimplementingcontract.ConfigurationBlockContext(same as subnet-evm)core.NewBlockContextto converttypes.Blockandtypes.Headerfor calls tocore.ApplyUpgradesHow this was tested
Existing CI passing
Need to be documented?
No
Need to update RELEASES.md?
No