[WIP] Use libevm instead of go-ethereum #777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be closed once #820 gets merged, given go-ethereum is no longer imported anywhere in the libevm branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
libevmis fork ofgo-ethereumthat is currently at the same upstream version as we use here (v1.13.14). In case should want or need to back-port upstream changes fromgo-ethereumin the future without needing to fully update to a newer upstream version, we should import thelibevmpackages and remove the direct dependency ongo-ethereumentirely.How this works
Self-explanatory
How this was tested
CI
Need to be documented in RELEASES.md?
No