Skip to content

chore(all): minimal changes for libevm v1.13.14-0.2.0.rc.3 (1) #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 20, 2025
Merged

chore(all): minimal changes for libevm v1.13.14-0.2.0.rc.3 (1) #811

merged 12 commits into from
Feb 20, 2025

Conversation

darioush
Copy link

@darioush darioush commented Feb 18, 2025 •
edited by qdm12
Loading

This should be the first pull request to get merged into libevm in the series of libevm-phase-2.5 PRs.

PRs plan

(each of these branches are based off the previous one)

  1. This PR: minimal changes for libevm v1.13.14-0.2.0.rc.3
  2. Merge master into libevm Merge master (2e4e6bd) into libevm (2) #812
  3. Re-structure code a bit (no PR yet) using branch qdm12/libevm/structure
  4. Header extra RLP+JSON implementation PR: chore(core/types): header JSON and RLP serialization hooks (4) #746
  5. Header extra PostCopy hook PR: chore(core/types): Header libevm PostCopy hook (5) #759
  6. Body + Block hooks PR: chore(core/types): remove block.go and import Block and Body from libevm (6) #760
  7. core/rawdb InspectDatabase test chore(core/rawdb): add ExampleInspectDatabase to check custom behavior (7) #790
  8. core/rawdb InspectDatabase uses libevm chore(core/rawdb): InspectDatabase uses libevm (8) #791
  9. core/rawdb full replacement chore(core/rawdb): use libevm core/rawdb #772

qdm12 and others added 6 commits February 10, 2025 15:40
@qdm12
chore(all): minimal changes for last libevm dependency
ab19679 
- Uses tip of main libevm dependency + cherry picked commit: ava-labs/libevm@d3f6a5e
- Precompile legacy gas fix (done in ava-labs/libevm@f906679)
- Added `HeaderExtra` not-implemented implementation
- Minimal changes shamelessly copied over from #746
@qdm12
Bump libevm dependency to current main
fe9ce00 
At commit ava-labs/libevm@9c7285a
@qdm12
Bump libevm dependency to current main
4e68587 
At commit ava-labs/libevm@19ec675
@qdm12
Bump libevm dependency to current main
32a879f 
At commit ava-labs/libevm@bd9b506
@qdm12
Bump libevm to v1.13.14-0.1.0.rc-2
a8710a4
@holiman @MariusVanDerWijden @qdm12
ci: bump golang to 1.23.6 (#805)
1145574 
Co-authored-by: Martin HS <[email protected]>
Co-authored-by: Marius van der Wijden <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
@darioush darioush changed the title chore(all): minimal changes for last libevm dependency Step 1. Bump libevm dependency in coreth Feb 18, 2025
@darioush darioush changed the title Step 1. Bump libevm dependency in coreth chore(all): minimal changes for last libevm dependency (1) Feb 18, 2025
@qdm12 qdm12 mentioned this pull request Feb 19, 2025
Closed
qdm12
qdm12 previously approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niceee 👍 !

@qdm12 qdm12 mentioned this pull request Feb 19, 2025
Closed
@qdm12 qdm12 marked this pull request as ready for review February 19, 2025 08:58
@qdm12 qdm12 requested review from a team and ceyonur as code owners February 19, 2025 08:58
@qdm12 qdm12 changed the title chore(all): minimal changes for last libevm dependency (1) chore(all): minimal changes for libevm v1.13.14-0.2.0.rc.3 (1) Feb 19, 2025
ARR4N
ARR4N reviewed Feb 19, 2025
View reviewed changes
@qdm12 qdm12 force-pushed the darioush/qdm12/libevm-phase-2.5 branch from 6f05cd5 to b7f8655 Compare February 19, 2025 10:16
@qdm12 qdm12 force-pushed the darioush/qdm12/libevm-phase-2.5 branch from 6267f42 to 8b6952c Compare February 19, 2025 17:44
ARR4N
ARR4N approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@ARR4N ARR4N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@darioush darioush enabled auto-merge (squash) February 19, 2025 22:55
qdm12
qdm12 reviewed Feb 20, 2025
View reviewed changes
@qdm12 qdm12 disabled auto-merge February 20, 2025 08:44
@qdm12 qdm12 merged commit 342bf3a into libevm Feb 20, 2025
6 checks passed
@qdm12 qdm12 deleted the darioush/qdm12/libevm-phase-2.5 branch February 20, 2025 11:19
ARR4N added a commit that referenced this pull request Mar 10, 2025
@qdm12 @ARR4N
chore(all): minimal changes for libevm v1.13.14-0.2.0.rc.3 (#811)
a295e40 
Co-authored-by: Quentin Mc Gaw <[email protected]>
Co-authored-by: Arran Schlosberg <[email protected]>
@qdm12 qdm12 mentioned this pull request Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ARR4N ARR4N ARR4N approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

+1 more reviewer

@qdm12 qdm12 qdm12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@darioush @ARR4N @qdm12