Skip to content

fix(metrics/prometheus): skip metric types GaugeInfo #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

fix(metrics/prometheus): skip metric types GaugeInfo #910

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91be79b
fix(metrics/prometheus): add case for `StandardGaugeInfo` to skip
qdm12 Apr 8, 2025
662de26
Pointer type
qdm12 Apr 8, 2025
0ac2459
Update test
qdm12 Apr 8, 2025
3582d81
Use metrics.GaugeInfo
qdm12 Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions metrics/prometheus/prometheus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ func metricFamily(registry Registry, name string) (mf *dto.MetricFamily, err err
},
}},
}, nil
case metrics.StandardGaugeInfo:
// TODO(qdm12) handle this somehow maybe with dto.MetricType_UNTYPED
return nil, fmt.Errorf("%w: %q is a %T", errMetricSkip, name, metric)
default:
return nil, fmt.Errorf("metric %q: type is not supported: %T", name, metric)
}
Expand Down
Loading