Skip to content

Conversation

qdm12
Copy link
Contributor

@qdm12 qdm12 commented May 16, 2025

Why this should be merged

Ported from subnet-evm's merged PR ava-labs/subnet-evm#1563

How this works

  • Move coreth specific params from params/protocol_params.go to params/protocol_params_ext.go
  • Use upstream protocol params and delete params/protocol_params.go
  • TestUpstreamParamsValues is a change detector test to detect a geth params change in a future upgrade to make sure we take it into account.

How this was tested

Existing CI passing

Need to be documented?

No

Need to update RELEASES.md?

No

@qdm12 qdm12 marked this pull request as ready for review May 16, 2025 12:40
@qdm12 qdm12 requested a review from a team as a code owner May 16, 2025 12:40
@JonathanOppenheimer JonathanOppenheimer requested a review from a team as a code owner August 5, 2025 18:28
@JonathanOppenheimer JonathanOppenheimer requested review from alarso16 and removed request for alarso16 August 5, 2025 19:36
@maru-ava maru-ava removed their request for review August 25, 2025 15:06
@StephenButtolph
Copy link
Contributor

didn't review, but merging as Cey reviewed

@StephenButtolph StephenButtolph added this pull request to the merge queue Aug 25, 2025
Merged via the queue into master with commit 3263334 Aug 25, 2025
9 checks passed
@StephenButtolph StephenButtolph deleted the qdm12/upstream-params branch August 25, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants