feat: join two key proofs into one trie#1396
Draft
demosdemon wants to merge 1 commit intobrandon.leblanc/proof-triefrom
Draft
feat: join two key proofs into one trie#1396demosdemon wants to merge 1 commit intobrandon.leblanc/proof-triefrom
demosdemon wants to merge 1 commit intobrandon.leblanc/proof-triefrom
Conversation
demosdemon
force-pushed
the
brandon.leblanc/proof-trie
branch
from
f67a1af to
a1daa93
Compare
demosdemon
force-pushed
the
brandon.leblanc/joined-key-proofs
branch
from
55574bd to
c0d037d
Compare
demosdemon
force-pushed
the
brandon.leblanc/proof-trie
branch
from
a1daa93 to
a3246b0
Compare
demosdemon
force-pushed
the
brandon.leblanc/proof-trie
branch
from
a3246b0 to
497272d
Compare
demosdemon
force-pushed
the
brandon.leblanc/joined-key-proofs
branch
from
c0d037d to
7d6fdba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for merging key proof tries to create key range proof tries, along with error handling for merge failures and corresponding test coverage.
KeyRangeProofTrieRootto represent the merged result of zero, one, or two key proof tries, allowing construction of a trie that bounds a key range. This includes logic for merging tries and handling unbounded ranges.mergeandmerge_optmethods forKeyProofTrieRootandKeyProofTrieNode, enabling iterative merging of key proof tries and their nodes.MergeKeyProofErrorfor detailed errors of merge failures, including disjoint edges, disjoint children, differing hashes, and duplicate keys with different values.