Draft
Conversation
demosdemon
force-pushed
the
brandon.leblanc/check-hash-on-read
branch
3 times, most recently
from
d1debb0 to
b148409
Compare
demosdemon
force-pushed
the
brandon.leblanc/check-hash-on-read
branch
from
e11e12b to
1d72261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we read nodes from storage, we currently assume the data is consistent and return it as-is to the caller. However, that is a bad assumption as data on disk can easily be corrupted. As an extreme example, cosmic background radiation can cause bit flips for non-ECC hardware. And as a more realistic example, there could be a bug in Firewood that causes data to be overwritten or serialized incorrectly.
This change adds verifying reads to the database, with two exceptions. Reading the root upon opening the database is unable to verify the root hash. Unless we're running with a root store, the root hash will be unknown to firewood on startup. This likely means we should include the root hash in the header. I will revisit that soon. Additionally, reading leaked areas via the fsck util is unable to verify the hash; which is to be expected for a leaked area.