fix(bootstrap): Enable bootstrap metrics listener#1579
Draft
Conversation
Due to a change in avalanchego, we're no longer collecting metrics
locally when running the bootstrapping tests. This was super convenient
before, and adding new metrics and changing dashboards is much harder
without this test grafana environment working.
This appears to be the result of several separate problems:
1. Avalanchego doesn't enable a prometheus listener on port 6060, most
likely due to the changes in ava-labs/avalanchego#4418.
2. Firewood is no longer opened with a prometheus listener on port
3000.
3. Firewood does not enable the metrics server when opening the
database, unless expensive metrics are enabled.
I think we don't want firewood listening directly, so I'm not fixing #2.
However, prometheus should still attempt to listen on port 3000 for the
other benchmark tests, so I'm leaving the prometheus listener running on
that port for launched instances.
Issue #3 is a problem in avalanchego. We probably should not consider
all metrics expensive though, so we should initialize the metrics server
regardless of this setting. This is a separate avalanchego bug that
should be fixed as part of #1524
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a change in avalanchego, we're no longer collecting metrics locally when running the bootstrapping tests. This was super convenient before, and adding new metrics and changing dashboards is much harder without this test grafana environment working.
This appears to be the result of several separate problems:
I think we don't want firewood listening directly, so I'm not fixing #2. However, prometheus should still attempt to listen on port 3000 for the other benchmark tests, so I'm leaving the prometheus listener running on that port for launched instances.
Issue #3 is a problem in avalanchego. We probably should not consider all metrics expensive though, so we should initialize the metrics server regardless of this setting. This is a separate avalanchego bug that should be fixed as part of #1524
Why this should be merged
How this works
How this was tested