chore: add deferred persistence benchmark#1670
Merged
RodrigoVillar merged 1 commit intomainfrom Feb 16, 2026
Merged
Conversation
RodrigoVillar
force-pushed
the
rodrigo/async-persist-every-n-commits
branch
from
25a16aa to
461d452
Compare
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
from
ec8b9c6 to
56e9247
Compare
RodrigoVillar
force-pushed
the
rodrigo/async-persist-every-n-commits
branch
from
461d452 to
f81e3ea
Compare
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
2 times, most recently
from
e8bcb7d to
558e548
Compare
RodrigoVillar
force-pushed
the
rodrigo/async-persist-every-n-commits
branch
2 times, most recently
from
f044ec9 to
e2d972f
Compare
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
from
558e548 to
73c824e
Compare
RodrigoVillar
force-pushed
the
rodrigo/async-persist-every-n-commits
branch
from
e2d972f to
58d5bb3
Compare
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
2 times, most recently
from
5bcc282 to
dd3d85f
Compare
RodrigoVillar
force-pushed
the
rodrigo/async-persist-every-n-commits
branch
3 times, most recently
from
82dd5fd to
e1e70ce
Compare
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
from
dd3d85f to
eea5be4
Compare
RodrigoVillar
force-pushed
the
rodrigo/async-persist-every-n-commits
branch
from
e1e70ce to
d54468a
Compare
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
from
eea5be4 to
3dcbcc6
Compare
Base automatically changed from
rodrigo/async-persist-every-n-commits
to
main
February 13, 2026 21:00
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
from
3dcbcc6 to
25321b5
Compare
RodrigoVillar
requested review from
bernard-avalabs,
demosdemon and
rkuris
as code owners
rkuris
approved these changes
Feb 16, 2026
| fn bench_deferred_persistence<const N: usize, const COMMIT_COUNT: u64>(criterion: &mut Criterion) { | ||
| const KEY_LEN: usize = 4; | ||
| let rng = &firewood_storage::SeededRng::from_option(Some(1234)); | ||
| let commit_count = NonZeroU64::new(COMMIT_COUNT).unwrap(); |
Member
There was a problem hiding this comment.
super nit: nonzero macro would have worked here since it's a compile time constant.
Contributor
Author
There was a problem hiding this comment.
Unfortunately, applying the nonzero macro here fails as seen below:
generic parameters may not be used in const operations
const parameters may only be used as standalone arguments here, i.e. `COMMIT_COUNT`
firewood/benches/defer_persist.rs
Outdated
| criterion_group! { | ||
| name = benches; | ||
| config = Criterion::default(); | ||
| targets = bench_deferred_persistence::<1_000, 1>, bench_deferred_persistence::<1_000, 100> |
Member
There was a problem hiding this comment.
nit: comment explaining why 1, 100, and 1000 was chosen. I realize we never did this earlier, and maybe there aren't any good reasons :)
Contributor
Author
There was a problem hiding this comment.
I chose these values on the fly. However, this does call out a good point - these benchmarks could do a better job in showing the performance gain (or loss) from choosing different commit counts. I went ahead and added more benchmark targets to get a performance curve from persisting every commit to persisting just once.
RodrigoVillar
force-pushed
the
rodrigo/add-defer-persist-benchmark
branch
from
25321b5 to
2ecddcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Having benchmarks to test the performance of deferred persistence across different commit counts is useful for observability.
How this works
Adds a benchmark
bench_deferred_persistence()to test deferred persistence with commit counts1and100. This benchmark is run daily along with our other benchmarks.How this was tested
CI