Open
Conversation
alarso16
force-pushed
the
alarso16/remove-hash-error
branch
from
599a32c to
23631fa
Compare
alarso16
requested review from
RodrigoVillar,
bernard-avalabs,
demosdemon and
rkuris
as code owners
alarso16
commented
Feb 11, 2026
| defer db.handleLock.RUnlock() | ||
| if db.handle == nil { | ||
| return EmptyRoot, errDBClosed | ||
| return EmptyRoot |
Contributor
Author
There was a problem hiding this comment.
This is the crux of the PR. There are no other possible errors, so it would be really nice to not have deal with this, but it's kind of strange behavior
demosdemon
reviewed
Feb 11, 2026
demosdemon
approved these changes
Feb 11, 2026
demosdemon
changed the title
demosdemon
changed the title
Contributor
|
Since this is a breaking change for the Go api, we should wait to merge until after 0.1.1 is released. |
rkuris
approved these changes
Feb 11, 2026
Member
rkuris
left a comment
rkuris
left a comment
There was a problem hiding this comment.
Yeah there's no way to get an error from a revision since the hashes are known before the call is made.
This is a breaking change so let's not merge it until 0.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I realized that the error returned by the hash function can only happen if the db handle is empty. Otherwise, it will always be nil. Why even give the opportunity to return an error?
How this works
Removes errors from the signature for everything hash-related.
How this was tested
CI