Skip to content

chore: add persist and RootStore metrics#1680

Open
RodrigoVillar wants to merge 1 commit intomainfrom
rodrigo/add-persist-and-rootstore-metrics
Open

chore: add persist and RootStore metrics#1680
RodrigoVillar wants to merge 1 commit intomainfrom
rodrigo/add-persist-and-rootstore-metrics

Conversation

@RodrigoVillar
Copy link
Contributor

@RodrigoVillar RodrigoVillar commented Feb 13, 2026

Why this should be merged

With the time-to-persist now decoupled from the time-to-commit, it would be great if we could capture data on how long it takes to persist + other similar processes.

How this works

  • Adds timer to track how long it takes to persist
  • Adds timer to track how long it takes to persisting root addresses to RootStore
  • Adds counter to track how many times we block on commit

How this was tested

CI

@github-actions
Copy link

github-actions bot commented Feb 13, 2026

Metrics Change Detection ⚠️

This PR contains changes related to metrics:

+    describe_counter!(
+    describe_counter!(PERSIST_TOTAL, "Number of persist operations");
+    describe_counter!(PERSIST_TOTAL_MS, "Persist latency (ms)");
+    describe_counter!(PERSIST_ROOT_STORE, "Number of root store save operations");
+    describe_counter!(PERSIST_ROOT_STORE_MS, "Root store save latency (ms)");

However, the dashboard was not modified.

You may need to update benchmark/Grafana-dashboard.json accordingly.


This check is automated to help maintain the dashboard.

@RodrigoVillar RodrigoVillar force-pushed the rodrigo/add-defer-persist-benchmark branch from eea5be4 to 3dcbcc6 Compare February 13, 2026 20:53
@RodrigoVillar RodrigoVillar force-pushed the rodrigo/add-persist-and-rootstore-metrics branch from 8df06b5 to b2140c1 Compare February 13, 2026 20:53
@RodrigoVillar RodrigoVillar force-pushed the rodrigo/add-defer-persist-benchmark branch from 3dcbcc6 to 25321b5 Compare February 13, 2026 21:07
@RodrigoVillar RodrigoVillar force-pushed the rodrigo/add-persist-and-rootstore-metrics branch from b2140c1 to a416fe5 Compare February 13, 2026 21:07
@RodrigoVillar RodrigoVillar force-pushed the rodrigo/add-defer-persist-benchmark branch from 25321b5 to 2ecddcb Compare February 16, 2026 15:06
Base automatically changed from rodrigo/add-defer-persist-benchmark to main February 16, 2026 15:13
@RodrigoVillar RodrigoVillar force-pushed the rodrigo/add-persist-and-rootstore-metrics branch from a416fe5 to d1f641e Compare February 16, 2026 15:25
@RodrigoVillar RodrigoVillar self-assigned this Feb 16, 2026
@RodrigoVillar
Copy link
Contributor Author

Happy to add these metrics to our existing local dashboard if requested, but with @Elvis339 creating a new set of dashboards, it might make more sense to add these new metrics there rather than migrating.

@RodrigoVillar RodrigoVillar marked this pull request as ready for review February 16, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant