Open
Conversation
RodrigoVillar
force-pushed
the
rodrigo/clarify-deferred-persistence-terminology
branch
3 times, most recently
from
90c9fd8 to
9f29c24
Compare
RodrigoVillar
force-pushed
the
rodrigo/reap-after-persisting
branch
from
1ca6d10 to
3bd3742
Compare
RodrigoVillar
changed the title
RodrigoVillar
force-pushed
the
rodrigo/reap-after-persisting
branch
3 times, most recently
from
a6eb2df to
e9234fe
Compare
Base automatically changed from
rodrigo/clarify-deferred-persistence-terminology
to
main
March 6, 2026 11:55
RodrigoVillar
force-pushed
the
rodrigo/reap-after-persisting
branch
from
e9234fe to
3998344
Compare
RodrigoVillar
force-pushed
the
rodrigo/reap-after-persisting
branch
from
3998344 to
51843c1
Compare
RodrigoVillar
requested review from
bernard-avalabs,
demosdemon and
rkuris
as code owners
demosdemon
approved these changes
Mar 6, 2026
bernard-avalabs
approved these changes
Mar 6, 2026
rkuris
requested changes
Mar 6, 2026
Member
rkuris
left a comment
rkuris
left a comment
There was a problem hiding this comment.
I would much rather prevent reaping of unpersisted revisions. We already have a mechanism for deferring putting them on the queue for reaping if they are actively being used. We should add a test that verifies that it's been fully persisted as well, which I think is much simpler than this restructuring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes the bug described in #1737 by first persisting revisions before reaping nodestores in deferred persistence.
How this works
reap()no longer wakes up the background threadpopreturns in theevent_loop, we first persist and then reapHow this was tested
CI + added regression test
Breaking Changes